Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to collect resources from objc_library implementation_deps #1970

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ivan-golub
Copy link
Contributor

With bazelbuild/bazel#17962 implementation deps is another potential source of resources so need to be handled in aspect

@brentleyjones
Copy link
Collaborator

Are there some tests you can change or add to make sure we don't regress this?

@ivan-golub
Copy link
Contributor Author

brentleyjones commented 1 hour ago
Are there some tests you can change or add to make sure we don't regress this?

Great suggestion. Added

inherited_providers = []
provider_deps = ["deps"] + collect_args.get("res_attrs", [])
provider_deps = ["deps"] + ["implementation_deps"] + collect_args.get("res_attrs", [])
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason to not simplify this list addition?

Suggested change
provider_deps = ["deps"] + ["implementation_deps"] + collect_args.get("res_attrs", [])
provider_deps = ["deps", "implementation_deps"] + collect_args.get("res_attrs", [])

mkdir -p app/shared_res
echo shared_res > app/shared_res/foo.txt

do_build ios //app:app || fail "Should build"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nit]

Suggested change
do_build ios //app:app || fail "Should build"
do_build ios //app:app || fail "Should build"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants